Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logger (vsnprintf consumes args) #917

Merged
merged 2 commits into from
Oct 14, 2022
Merged

Fix logger (vsnprintf consumes args) #917

merged 2 commits into from
Oct 14, 2022

Conversation

Nyrio
Copy link
Contributor

@Nyrio Nyrio commented Oct 14, 2022 •
edited
Loading

I noticed debug logs displayed nonsensical values so I had a look at the logger code and found it incorrect. Indeed vsnprintf consumes the arg list, so in order to call it twice, one must make a copy of the arg list.

@Nyrio Nyrio requested a review from a team as a code owner October 14, 2022 14:51
@github-actions github-actions bot added the cpp label Oct 14, 2022
@Nyrio Nyrio added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Oct 14, 2022
@cjnolet
Copy link
Member

cjnolet commented Oct 14, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5f56933 into rapidsai:branch-22.12 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nyrio @cjnolet